[navigation] Left navigation collective #7655

SuZhou-Joe · 2024-08-08T07:01:45Z

Description

The PR is to fix some issues:

Issues Resolved

Screenshot

Change category to manage workspace

Change the scrollable area of left navigation.

20240813183743370.mp4

Change the top icon behavior.

Add descriptions to some of core apps.

Append navLinks inside second level to custom category if no entry for the nav group

Testing the changes

Changelog

feat: [navigation] Left navigation collective

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

codecov · 2024-08-08T07:16:40Z

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (36af5e7) to head (5352851).
Report is 7 commits behind head on main.

Files	Patch %	Lines
...gins/workspace/public/services/use_case_service.ts	58.33%	3 Missing and 2 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx	87.50%	0 Missing and 2 partials ⚠️
...me/ui/header/collapsible_nav_group_enabled_top.tsx	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7655      +/-   ##
==========================================
- Coverage   63.75%   63.74%   -0.01%     
==========================================
  Files        3639     3639              
  Lines       80461    80460       -1     
  Branches    12800    12806       +6     
==========================================
- Hits        51297    51290       -7     
- Misses      26028    26077      +49     
+ Partials     3136     3093      -43

Flag	Coverage Δ
Linux_1	`29.86% <27.50%> (+0.01%)`	⬆️
Linux_2	`55.82% <87.50%> (-0.01%)`	⬇️
Linux_3	`40.39% <0.00%> (-0.01%)`	⬇️
Linux_4	`31.29% <4.00%> (-0.02%)`	⬇️
Windows_1	`29.87% <27.50%> (+0.01%)`	⬆️
Windows_2	`55.77% <87.50%> (-0.01%)`	⬇️
Windows_3	`40.39% <0.00%> (+<0.01%)`	⬆️
Windows_4	`31.29% <4.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…try for the nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl

Left a few minor comments

src/core/public/chrome/ui/header/collapsible_nav_group_enabled_top.tsx

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

opensearch-trigger-bot · 2024-08-16T00:38:57Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7655-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6877beaadd517207722c261181c1751bfa5bfb40
# Push it to GitHub
git push --set-upstream origin backport/backport-7655-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7655-to-2.x.

* feat: change nav groups Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7655 created/updated * feat: move visualizations to all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change the scrollable area Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: register manage workspace category when in a workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: register index patterns to settings and setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: show correct icon in top Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use gap to replace margin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make new left nav work in mobile mode Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: justify content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add descriptions to core features Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add description to index pattern Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use smaller font size in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: append navLinks inside second level to custom category if no entry for the nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: filter all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6877bea)

* feat: change nav groups Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7655 created/updated * feat: move visualizations to all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change the scrollable area Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: register manage workspace category when in a workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: register index patterns to settings and setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: show correct icon in top Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use gap to replace margin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make new left nav work in mobile mode Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: justify content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add descriptions to core features Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add description to index pattern Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use smaller font size in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: append navLinks inside second level to custom category if no entry for the nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: filter all use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6877bea)

feat: change nav groups

d49631d

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

github-actions bot added all-star-contributor failed changeset labels Aug 8, 2024

Changeset file for PR opensearch-project#7655 created/updated

f09e773

github-actions bot removed the failed changeset label Aug 8, 2024

SuZhou-Joe added 14 commits August 8, 2024 15:37

feat: move visualizations to all use case

f92e4f5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: change the scrollable area

b72e508

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: merge main

54fdae4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: register manage workspace category when in a workspace

9651bc1

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: register index patterns to settings and setup

3110391

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: show correct icon in top

baacc38

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use gap to replace margin

b4246ce

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make new left nav work in mobile mode

c817bb3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: bootstrap error

f3d3427

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: merge main

0c2feca

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test error

e91c997

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: justify content

2e7cc01

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test

4705ac8

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

fix: unit test

fe1329f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

opensearch-project deleted a comment from github-actions bot Aug 13, 2024

SuZhou-Joe added 5 commits August 13, 2024 18:23

Merge branch 'main' into feature/left-nav-2.17

b856c3e

feat: add descriptions to core features

7df3fca

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add description to index pattern

c0c543d

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use smaller font size in left nav

b4b421c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: append navLinks inside second level to custom category if no en…

585e01d

…try for the nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added backport 2.x v2.17.0 navigation labels Aug 14, 2024

Merge branch 'main' into feature/left-nav-2.17

8beff2b

SuZhou-Joe requested review from xinruiba, zhyuanqi, mengweieric, LDrago27, virajsanghvi, sejli and joshuali925 as code owners August 14, 2024 03:32

ruanyl previously approved these changes Aug 14, 2024

View reviewed changes

feat: some optimize

bec5b08

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe dismissed ruanyl’s stale review via bec5b08 August 14, 2024 10:01

SuZhou-Joe added 3 commits August 14, 2024 18:33

feat: optimize code

049a7e8

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: fix unit test

ddda8ca

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: filter all use case

9b168a2

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl previously approved these changes Aug 14, 2024

View reviewed changes

fix: unit test

1e703dc

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe dismissed ruanyl’s stale review via 1e703dc August 15, 2024 03:24

merge main

71587aa

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl previously approved these changes Aug 15, 2024

View reviewed changes

feat: merge main

5352851

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe dismissed ruanyl’s stale review via 5352851 August 15, 2024 08:50

ananzh approved these changes Aug 15, 2024

View reviewed changes

ruanyl approved these changes Aug 16, 2024

View reviewed changes

SuZhou-Joe merged commit 6877bea into opensearch-project:main Aug 16, 2024
67 checks passed

opensearch-trigger-bot bot added the failed backport label Aug 16, 2024

SuZhou-Joe mentioned this pull request Aug 16, 2024

[Backport 2.x] [navigation] Left navigation collective #7728

Merged

7 tasks

AMoo-Miki removed the failed backport label Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation] Left navigation collective #7655

[navigation] Left navigation collective #7655

SuZhou-Joe commented Aug 8, 2024 •

edited

Loading

codecov bot commented Aug 8, 2024 •

edited

Loading

ruanyl left a comment

opensearch-trigger-bot bot commented Aug 16, 2024

[navigation] Left navigation collective #7655

[navigation] Left navigation collective #7655

Conversation

SuZhou-Joe commented Aug 8, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Change category to manage workspace

Change the scrollable area of left navigation.

Change the top icon behavior.

Add descriptions to some of core apps.

Append navLinks inside second level to custom category if no entry for the nav group

Testing the changes

Changelog

Check List

codecov bot commented Aug 8, 2024 • edited Loading

Codecov Report

ruanyl left a comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Aug 16, 2024

SuZhou-Joe commented Aug 8, 2024 •

edited

Loading

codecov bot commented Aug 8, 2024 •

edited

Loading